Attention is currently required from: Martin Roth, Tim Van Patten.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74745 )
Change subject: mb/google/myst: Add initial memory configuration
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/myst/variants/myst/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/74745/comment/22dac321_164d21e0
PS1, Line 7: spd-2.hex
I mean it's fine for the build, but why is the first (and only) spd called spd-2? […]
Skyrim and Myst programs are using the same SPDs and that parts were added a little later in Skyrim program. Hence spd-2.hex
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a4fe9a41f101ac10391756f1b815220c8b98612
Gerrit-Change-Number: 74745
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Comment-Date: Tue, 02 May 2023 21:33:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Gerrit-MessageType: comment