build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35783 )
Change subject: [WIP]sb/intel/common: Handle legacy save states properly ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35783/1/src/southbridge/intel/commo... File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/35783/1/src/southbridge/intel/commo... PS1, Line 229: return EM64T; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35783/1/src/southbridge/intel/commo... PS1, Line 351: void *state = smi_apmc_find_state_save(apm_cnt); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35783/1/src/southbridge/intel/commo... PS1, Line 351: void *state = smi_apmc_find_state_save(apm_cnt); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35783/1/src/southbridge/intel/commo... PS1, Line 353: switch (get_save_state_type()) { code indent should use tabs where possible