[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add VR config for CFL, CNL and WHL

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37466 )

Change subject: soc/intel/cannonlake: Add VR config for CFL, CNL and WHL
......................................................................

Patch Set 8:

(2 comments)

https://review.coreboot.org/c/coreboot/+/37466/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/37466/7//COMMIT_MSG@11 
PS7, Line 11: replace
> replace*able*

Done

https://review.coreboot.org/c/coreboot/+/37466/7/src/soc/intel/cannonlake/vr... 
File src/soc/intel/cannonlake/vr_config.c:

https://review.coreboot.org/c/coreboot/+/37466/7/src/soc/intel/cannonlake/vr... 
PS7, Line 311: 	/* If board provided non-zero value, use it. */
> Could use the ternary operator: […]

Yes, it could be used.