[coreboot-gerrit] Change in coreboot[master]: mb/ocp/deltalake: Add SMM console log level override

[Angel Pons (Code Review)]

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47006 )

Change subject: mb/ocp/deltalake: Add SMM console log level override
......................................................................

Patch Set 3:

(1 comment)

File src/mainboard/ocp/deltalake/loglevel_vpd.c:

https://review.coreboot.org/c/coreboot/+/47006/comment/0dab655c_5e55688e 
PS3, Line 26: int log_level = SMM_LOG_LEVEL_DEFAULT;
            : 
            : 	if (vpd_get_int(SMM_LOG_LEVEL, VPD_RW_THEN_RO, (int *const) &log_level)) {
            : 		if (log_level < 0 || log_level >= BIOS_NEVER)
            : 			log_level = SMM_LOG_LEVEL_DEFAULT;
            : 	}
            : 	return log_level;
To avoid duplicating code, I would extract the common stuff into a helper function:

static int get_loglevel_from_vpd(const char *const key, const int fallback)
 {
    int log_level = fallback;

if (vpd_get_int(key, VPD_RW_THEN_RO, &log_level)) {
    	if (log_level < 0 || log_level >= BIOS_NEVER)
    		log_level = fallback;
    }
    return log_level;
 }