Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin.
1 comment:
File src/mainboard/ocp/deltalake/loglevel_vpd.c:
int log_level = SMM_LOG_LEVEL_DEFAULT;
if (vpd_get_int(SMM_LOG_LEVEL, VPD_RW_THEN_RO, (int *const) &log_level)) {
if (log_level < 0 || log_level >= BIOS_NEVER)
log_level = SMM_LOG_LEVEL_DEFAULT;
}
return log_level;
To avoid duplicating code, I would extract the common stuff into a helper function:
static int get_loglevel_from_vpd(const char *const key, const int fallback)
{
int log_level = fallback;
if (vpd_get_int(key, VPD_RW_THEN_RO, &log_level)) {
if (log_level < 0 || log_level >= BIOS_NEVER)
log_level = fallback;
}
return log_level;
}
To view, visit change 47006. To unsubscribe, or for help writing mail filters, visit settings.