Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31707 )
Change subject: cbfstool: Support new FMD flag "PRESERVE"
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31707/3/util/cbfstool/fmd_parser.y
File util/cbfstool/fmd_parser.y:
https://review.coreboot.org/#/c/31707/3/util/cbfstool/fmd_parser.y@111
PS3, Line 111: region_flag: FLAG_PRESERVE { $$.v = 0; $$.f.preserve = 1; };
Does this work if both flags are set?
yes, that will be handled by line 109.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31707
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51e7d31029b98868a1cab0d26bf04a14db01b1c0
Gerrit-Change-Number: 31707
Gerrit-PatchSet: 3
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Mar 2019 00:06:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment