[coreboot-gerrit] [S] Change in coreboot[master]: UPSTREAM: cbfstool: Fix possible memory leak

[Shahina Shaik (Code Review)]

Attention is currently required from: V Sowmya, Shahina Shaik, Haribalaraman Ramasubramanian, Sridhar Siricilla, Balaji Manigandan, Yu-Ping Wu.

Shahina Shaik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69220 )

Change subject: UPSTREAM: cbfstool: Fix possible memory leak
......................................................................

Patch Set 4:

(3 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/69220/comment/c0b0cc9e_f712be4e 
PS4, Line 7: UPSTREAM
> Please remove the `UPSTREAM` prefix.

Removed the "UPSTREAM" prefix from commit message.

File util/cbfstool/cbfstool.c:

https://review.coreboot.org/c/coreboot/+/69220/comment/d072e644_d8ac1c50 
PS4, Line 773: header_offset
> Take the chance to fix the indent (by aligning with `&image`)?

Fixed the indent as suggested.

File util/cbfstool/common.c:

https://review.coreboot.org/c/coreboot/+/69220/comment/308a1135_fc03680d 
PS4, Line 40: 		}
> Not related to your change, but I think writing `return -1` here is more straightforward

In line no:30, strdup is using malloc internally to allocate memory for the buffer->name, which has to be freed incase of there is no memory allocated for "buffer->data.