[coreboot-gerrit] [S] Change in coreboot[master]: util/amdfwtool/amdfwread: Fix incorrect option index

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Paul Menzel, Rob Barnes, Felix Held.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66553 )

Change subject: util/amdfwtool/amdfwread: Fix incorrect option index
......................................................................

Patch Set 7:

(1 comment)

File util/amdfwtool/amdfwread.c:

https://review.coreboot.org/c/coreboot/+/66553/comment/7794b91d_e94580b6 
PS6, Line 162: 	{"soft-fuse", no_argument, 0, AMDFW_OPT_SOFT_FUSE},
> According to the docs: […]

Yes, soft-fuse is at index 1 in long_option. With the previous version of code when no matching options were found, index was at 1 (since the previously matched option was soft-fuse). Hence incrementing the index was still within argc and everything was working fine. So we were just getting lucky.