Attention is currently required from: Wayne3 Wang, Hank Lin, Tim Wawrzynczak, Nick Vaccaro, Ken Lu, Zhuohao Lee.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50103 )
Change subject: mb/google/volteer/variants/drobit: Add TBT PCIE rp setting for drobit
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/volteer/variants/drobit/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/50103/comment/1be76477_b00c9d0e
PS1, Line 63: device ref tbt_pcie_rp0 on end
: device ref tbt_pcie_rp1 on end
I rewrite the CBI value of the system from 814206 to 814203. […]
Yes, you need to modify the config.star.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50103
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic0a4756b4af839ea0a23febb991bd71af7733dcc
Gerrit-Change-Number: 50103
Gerrit-PatchSet: 1
Gerrit-Owner: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Ariel Chang
ariel_chang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-Reviewer: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alex1 Kao
alex1_kao@pegatron.corp-partner.google.com
Gerrit-CC: Hao Chou
hao_chou@pegatron.corp-partner.google.com
Gerrit-CC: Kirk Wang
kirk_wang@pegatron.corp-partner.google.com
Gerrit-CC: Paul2 Huang
paul2_huang@pegatron.corp-partner.google.com
Gerrit-CC: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Attention: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Gerrit-Attention: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Mon, 01 Feb 2021 10:06:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Wayne3 Wang
wayne3_wang@pegatron.corp-partner.google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Comment-In-Reply-To: Zhuohao Lee
zhuohao@chromium.org
Gerrit-MessageType: comment