10 Dec
2020
10 Dec
'20
4:53 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48408 )
Change subject: nb/intel/sandybridge: Clean up stepping logic ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48408/3/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/48408/3/src/northbridge/intel/sandy... PS3, Line 277: is_sandy &&
I read `!is_sandy ||`?
Derp. Thanks.
https://review.coreboot.org/c/coreboot/+/48408/3/src/northbridge/intel/sandy... PS3, Line 282: is_sandy &&
Same here?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/48408
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27ad609eb53b96987ad5445301b5392055fa4ea1
Gerrit-Change-Number: 48408
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 10 Dec 2020 15:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment