[coreboot-gerrit] [S] Change in coreboot[master]: sb,soc/amd,intel: Apply minor FADT fixes

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74911 )

Change subject: sb,soc/amd,intel: Apply minor FADT fixes
......................................................................

sb,soc/amd,intel: Apply minor FADT fixes

Change-Id: I27a610255e5680be1b507d45c6695cf9419ee052
Signed-off-by: Kyösti Mälkki 
---
M src/soc/intel/jasperlake/acpi.c
M src/soc/intel/xeon_sp/spr/soc_acpi.c
M src/southbridge/amd/pi/hudson/fadt.c
M src/southbridge/intel/i82801dx/fadt.c
4 files changed, 19 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/74911/1

diff --git a/src/soc/intel/jasperlake/acpi.c b/src/soc/intel/jasperlake/acpi.c
index f00ff7a..4680e4d 100644
--- a/src/soc/intel/jasperlake/acpi.c
+++ b/src/soc/intel/jasperlake/acpi.c
@@ -156,7 +156,7 @@
    fadt->x_pm_tmr_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_pm_tmr_blk.bit_width = fadt->pm_tmr_len * 8;
    fadt->x_pm_tmr_blk.bit_offset = 0;
-	fadt->x_pm_tmr_blk.access_size = ACPI_ACCESS_SIZE_UNDEFINED;
+	fadt->x_pm_tmr_blk.access_size = ACPI_ACCESS_SIZE_DWORD_ACCESS;
    fadt->x_pm_tmr_blk.addrl = fadt->pm_tmr_blk;
    fadt->x_pm_tmr_blk.addrh = 0x0;

diff --git a/src/soc/intel/xeon_sp/spr/soc_acpi.c b/src/soc/intel/xeon_sp/spr/soc_acpi.c
index 18ebe72..c11cbc1 100644
--- a/src/soc/intel/xeon_sp/spr/soc_acpi.c
+++ b/src/soc/intel/xeon_sp/spr/soc_acpi.c
@@ -55,8 +55,8 @@
    fadt->x_pm2_cnt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_pm2_cnt_blk.bit_width = fadt->pm2_cnt_len * 8;
    fadt->x_pm2_cnt_blk.bit_offset = 0;
-	fadt->x_pm2_cnt_blk.access_size = ACPI_ACCESS_SIZE_UNDEFINED;
-	fadt->x_pm2_cnt_blk.addrl = pmbase + PM2_CNT;
+	fadt->x_pm2_cnt_blk.access_size = ACPI_ACCESS_SIZE_BYTE_ACCESS;
+	fadt->x_pm2_cnt_blk.addrl = fadt->pm2_cnt_blk;
    fadt->x_pm2_cnt_blk.addrh = 0x0;

/* PM1 Timer Register */
@@ -64,7 +64,7 @@
    fadt->x_pm_tmr_blk.bit_width = fadt->pm_tmr_len * 8;
    fadt->x_pm_tmr_blk.bit_offset = 0;
    fadt->x_pm_tmr_blk.access_size = ACPI_ACCESS_SIZE_DWORD_ACCESS;
-	fadt->x_pm_tmr_blk.addrl = pmbase + PM1_TMR;
+	fadt->x_pm_tmr_blk.addrl = fadt->pm_tmr_blk;
    fadt->x_pm_tmr_blk.addrh = 0x0;

fadt->x_gpe0_blk.space_id = ACPI_ADDRESS_SPACE_IO;
diff --git a/src/southbridge/amd/pi/hudson/fadt.c b/src/southbridge/amd/pi/hudson/fadt.c
index ff46857..f85b2d5 100644
--- a/src/southbridge/amd/pi/hudson/fadt.c
+++ b/src/southbridge/amd/pi/hudson/fadt.c
@@ -63,7 +63,7 @@
    fadt->x_pm1a_cnt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_pm1a_cnt_blk.bit_width = fadt->pm1_cnt_len * 8;
    fadt->x_pm1a_cnt_blk.bit_offset = 0;
-	fadt->x_pm1a_cnt_blk.access_size = ACPI_ACCESS_SIZE_UNDEFINED;
+	fadt->x_pm1a_cnt_blk.access_size = ACPI_ACCESS_SIZE_WORD_ACCESS;
    fadt->x_pm1a_cnt_blk.addrl = fadt->pm1a_cnt_blk;
    fadt->x_pm1a_cnt_blk.addrh = 0x0;

diff --git a/src/southbridge/intel/i82801dx/fadt.c b/src/southbridge/intel/i82801dx/fadt.c
index 4245e12..aeb7d45 100644
--- a/src/southbridge/intel/i82801dx/fadt.c
+++ b/src/southbridge/intel/i82801dx/fadt.c
@@ -26,28 +26,28 @@
    fadt->x_pm1a_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_pm1a_evt_blk.bit_width = fadt->pm1_evt_len * 8;
    fadt->x_pm1a_evt_blk.bit_offset = 0;
-	fadt->x_pm1a_evt_blk.access_size = ACPI_ACCESS_SIZE_UNDEFINED;
+	fadt->x_pm1a_evt_blk.access_size = ACPI_ACCESS_SIZE_WORD_ACCESS;
    fadt->x_pm1a_evt_blk.addrl = fadt->pm1a_evt_blk;
    fadt->x_pm1a_evt_blk.addrh = 0x0;

fadt->x_pm1a_cnt_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_pm1a_cnt_blk.bit_width = fadt->pm1_cnt_len * 8;
    fadt->x_pm1a_cnt_blk.bit_offset = 0;
-	fadt->x_pm1a_cnt_blk.access_size = ACPI_ACCESS_SIZE_UNDEFINED;
+	fadt->x_pm1a_cnt_blk.access_size = ACPI_ACCESS_SIZE_WORD_ACCESS;
    fadt->x_pm1a_cnt_blk.addrl = fadt->pm1a_cnt_blk;
    fadt->x_pm1a_cnt_blk.addrh = 0x0;

fadt->x_pm_tmr_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_pm_tmr_blk.bit_width = fadt->pm_tmr_len * 8;
    fadt->x_pm_tmr_blk.bit_offset = 0;
-	fadt->x_pm_tmr_blk.access_size = ACPI_ACCESS_SIZE_UNDEFINED;
+	fadt->x_pm_tmr_blk.access_size = ACPI_ACCESS_SIZE_DWORD_ACCESS;
    fadt->x_pm_tmr_blk.addrl = fadt->pm_tmr_blk;
    fadt->x_pm_tmr_blk.addrh = 0x0;

fadt->x_gpe0_blk.space_id = ACPI_ADDRESS_SPACE_IO;
    fadt->x_gpe0_blk.bit_width = fadt->gpe0_blk_len * 8;
    fadt->x_gpe0_blk.bit_offset = 0;
-	fadt->x_gpe0_blk.access_size = ACPI_ACCESS_SIZE_UNDEFINED;
+	fadt->x_gpe0_blk.access_size = ACPI_ACCESS_SIZE_BYTE_ACCESS;
    fadt->x_gpe0_blk.addrl = fadt->gpe0_blk;
    fadt->x_gpe0_blk.addrh = 0x0;
 }