Attention is currently required from: Kane Chen, Tim Wawrzynczak, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60401 )
Change subject: soc/intel/alderlake: Check clkreq overlap ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/60401/comment/5d57d65d_7ec8f94f PS3, Line 51: 32 bit nit: 32-bit
https://review.coreboot.org/c/coreboot/+/60401/comment/5f39782c_6813654e PS3, Line 55: u32 nit: uint32_t
Also, knowing the max number of PCIe RPs for ADL, you can safely use uint16_t i believe if you wish.
https://review.coreboot.org/c/coreboot/+/60401/comment/4f985e2b_2813472b PS3, Line 63: printk(BIOS_WARNING, "Found overlapped clkreq assignment on clk req %d\n" : , cfg[i].clk_req); how are we protecting the overlap now? just serial msg is enough or you would like to skip the overlapped assignment of the clkreq ?