Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45052 )
Change subject: soc/intel/tigerlake: Add Acoustic features
......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45052/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45052/9//COMMIT_MSG@11
PS9, Line 11: AcousticNoiseMitigation
: FastPkgCRampDisable
: SlowSlewRateFor
Can this be formatted as a list, e.g.,
```
- AcousticNoiseMitigation
- FastPkgCRampDisable
- SlowSlewRate
```
https://review.coreboot.org/c/coreboot/+/45052/9//COMMIT_MSG@14
PS9, Line 14: AcousticNoiseMitigation is the UPD for Acoustic Noise Mitigation.
: FastPkgCRampDisable UPD's are to disable Fast Slew Rate for Deep Package
: C States for VR domains.
: SlowSlewRate UPD's are the Slew Rate configuration for Deep Package C
: States for VR domains. Slew rates are fast time divided by 2.
This is already in the comments, I don't think it's required here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45052
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1924a3bac8beb16a9d841891696f9a3dea0d425f
Gerrit-Change-Number: 45052
Gerrit-PatchSet: 9
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Eric Herrmann
eherrmann@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Oct 2020 16:54:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment