1 Dec
2019
1 Dec
'19
2:55 a.m.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37344 )
Change subject: Add support for older EM100Pro ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/em100/+/37344/2/em100.c File em100.c:
https://review.coreboot.org/c/em100/+/37344/2/em100.c@921 PS2, Line 921: em100.hwversion == HWVERSION_EM100PRO_EARLY ? "DP" : "EM", Nit: Create a macro for this since the same logic is used in a couple other places in this file? Then again it might be overkill for now... Up to you.
--
To view, visit https://review.coreboot.org/c/em100/+/37344
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I18f19d83b515c4e740f1efec07d49c1ceb2373ec
Gerrit-Change-Number: 37344
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 01 Dec 2019 01:55:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment