Attention is currently required from: Kangheui Won.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61368 )
Change subject: psp_verstage: add new svc for cezanne
......................................................................
Patch Set 4:
(1 comment)
File src/vendorcode/amd/fsp/cezanne/include/bl_uapp/bl_syscall_public.h:
https://review.coreboot.org/c/coreboot/+/61368/comment/497222e7_ba472c32
PS4, Line 145: NON_CHROME_BOOK_BOOT_MODE = 0x0,
: CHROME_BOOK_BOOT_MODE_UNSIGNED_VERSTAGE = 0x1,
: CHROME_BOOK_BOOT_MODE_PRODUCTION = 0x2,
: CHROME_BOOK_BOOT_MODE_DEVELOPER = 0x3,
: CHROME_BOOK_BOOT_MODE_TYPE_MAX_LIMIT = 0x4, // used for boundary check
Please indent with a tab. It’d be great, if you sent a fix-up, as this seems to have slipped review.
Also, why is it necessary, to assign the values? Where are those defined?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61368
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6bcc9e49a2b73d486cfecd7b240bf989cad94630
Gerrit-Change-Number: 61368
Gerrit-PatchSet: 4
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Comment-Date: Wed, 02 Feb 2022 06:24:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment