Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39317 )
Change subject: soc/intel/tigerlake: Enable CNVi Mode
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39317/3/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/39317/3/src/soc/intel/tigerlake/fsp...
PS3, Line 153: params->CnviMode = config->CnviMode;
: params->CnviBtCore = config->CnviBtCore;
Sorry about the delayed review. I have 2 questions: […]
Furquan, for a) do you want me to use pcidev_on_root(PCH_DEV_SLOT_XHCI, 3) to determine if device is connected ?
b) Part for Cnvi Init is pad config, need to check what else is FSP doing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic372348a1409b2594a85b71b2fc742be96b84b87
Gerrit-Change-Number: 39317
Gerrit-PatchSet: 3
Gerrit-Owner: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 10 Mar 2020 06:44:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment