Jenny Tc has uploaded a new patch set (#5) to the change originally created by Jenny Tc. ( https://review.coreboot.org/c/coreboot/+/31635 )
Change subject: soc/intel/skylake: nhlt: Add 24-bit blobs for Max98373 ......................................................................
soc/intel/skylake: nhlt: Add 24-bit blobs for Max98373
Enable 24-bit nhlt blobs and remove 16-bit blobs. 16-bit and 24-bit blobs cannot be supported together since the OS NHLT parsing relies on container bit format. The container bit format for 16 and 24-bit capture are same (32) and putting both blobs in configs results in selecting the first blob. To enable 24 and 16-bit blobs together, the core nhlt parsing logic has to be changed which would impact SKL and KBL platforms. In order to minimize the impact, the 16-bit blob is removed considering that the machine driver for max98373 is expected to support only 24-bit format due to topology configuration.
The speaker IV channels for max98373 are changed to match with 24-bit topology firmware.
BUG=b:110795132 BRANCH=none TEST=Verify playback after flashing CQ-DEPEND=CL:1505199
Change-Id: I62cc109fb0aca9269736779a6ce80980b0571b78 Signed-off-by: Jenny TC jenny.tc@intel.com --- M src/mainboard/google/poppy/variants/atlas/devicetree.cb M src/mainboard/google/poppy/variants/nocturne/devicetree.cb M src/soc/intel/skylake/nhlt/Makefile.inc M src/soc/intel/skylake/nhlt/max98373.c 4 files changed, 14 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/31635/5