Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40782 )
Change subject: soc/amd/picasso: Drop _INI method for AZHD device
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40782/3/src/soc/amd/picasso/acpi/no...
File src/soc/amd/picasso/acpi/northbridge.asl:
https://review.coreboot.org/c/coreboot/+/40782/3/src/soc/amd/picasso/acpi/no...
PS3, Line 82: OperationRegion(AZPD, PCI_Config, 0x00, 0x100)
Please mention that you're dropping the OperationRegion as well
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40782
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If42abf91ee5cd47a881b0a3b4ca1916ea5169261
Gerrit-Change-Number: 40782
Gerrit-PatchSet: 3
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 28 Apr 2020 20:19:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment