Attention is currently required from: Jakub Czapiga, Julius Werner, Martin L Roth.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81081?usp=email )
Change subject: lib/device_tree: Add some FDT helper functions ......................................................................
Patch Set 18:
(2 comments)
File src/lib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/81081/comment/70004b13_3e7000bb : PS12, Line 200: if (!strncmp(*path, node_name, path_sub_len)) {
Don't we? It's used in acpigen and vboot/ec_sync, for example. […]
I changed it now to use a 'path_array' instead of the path directly (although personally I find the solutions are similar regarding complexity). I used an upper bound instead of `alloca`, because otherwise GCC complains and I don't want to add an extra pragma like in `src/acpi/acpigen.c`.
https://review.coreboot.org/c/coreboot/+/81081/comment/69301c61_d0563510 : PS12, Line 214: ince address-cells and size-cells are not inherited
I asked in this thread: […]
I am not sure what to do now. According to the issue, we should not treat them as inheritable.