Attention is currently required from: Henry Sun, Super Ni, Teddy Shih, Paul Menzel, Simon Yang, Aseda Aboagye, Ivan Chen, Karthik Ramasubramanian, Felix Held.
Teddy Shih has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63652 )
Change subject: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
Patchset:
PS4:
Hi Teddy, […]
Hi Simon,
For I2C clock frequency, I will remove the value of parameter speed_config until ECS HW's comment to ensure it.
I have checked the JSL I2C bus 0-5 according mainboard schematic [1]. As I2C bus 1 and 3 are unused, therefore I will set them to PchSerialIoDisabled.
Reference:
[1] https://drive.google.com/file/d/1ZO_Ba0UOBihc2teO0XPZnALM-xkhy9t2/view?usp=s...
[2] EVT schematic (V B 220207)
https://drive.google.com/file/d/1Tb6sPUu9BQmiu77HEhp_q43iWLMpstEf/view?usp=s...
Patchset:
PS8:
Dear All,
Thank you for all reviewers' comments. I have replied and modified CL regarding reviewers' comments. Please kindly review my CL.
Best Regards,
Teddy
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63652
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If172d13aa62503547227adf91f049ea50b948888
Gerrit-Change-Number: 63652
Gerrit-PatchSet: 8
Gerrit-Owner: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Reviewer: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-Reviewer: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Teddy Shih
teddyshihau@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eddy Lu
eddylu@ami.corp-partner.google.com
Gerrit-CC: Jack Cheng
jack.cheng@ecs.corp-partner.google.com
Gerrit-CC: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-Attention: Teddy Shih
teddyshihau@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 03 May 2022 17:23:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Simon Yang
simon1.yang@intel.com
Comment-In-Reply-To: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-MessageType: comment