Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/27009
Change subject: drivers/i2c/generic: Encure config is not NULL before accessing it ......................................................................
drivers/i2c/generic: Encure config is not NULL before accessing it
This change checks to ensure that config is not NULL before it is accessed for the first time.
Reported by: Coverity CID #1393312
Change-Id: Ic248c79783da9c2bfdf3b7f737e5963feff7558c Signed-off-by: Furquan Shaikh furquan@google.com --- M src/drivers/i2c/generic/generic.c 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/27009/1
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 7f1ce16..1b12df5 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -202,6 +202,9 @@ { struct drivers_i2c_generic_config *config = dev->chip_info;
+ if (!config) + return; + /* Check if device is present by reading GPIO */ if (config->device_present_gpio) { int present = gpio_get(config->device_present_gpio); @@ -219,9 +222,8 @@ dev->ops = &i2c_generic_ops;
/* Name the device as per description provided in devicetree */ - if (config && config->desc) { + if (config->desc) dev->name = config->desc; - } }
struct chip_operations drivers_i2c_generic_ops = {