Attention is currently required from: Jason Glenesk, Marshall Dawson, Tim Wawrzynczak, Nick Vaccaro, Kyösti Mälkki, Fred Reitberger, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59011 )
Change subject: [WIP] mb/google,intel: Split chromeos.c files
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
Do we have to split all these files up? I feel like GPIO setup and filling out the GPIO table belongs logically together (and it's nice to be able to see on one screen whether each GPIO in the table also gets initialized and vice versa).
lb_gpios() in coreboot_table.c is already guarded by CHROMEOS, so it wouldn't hurt to compile these for all configs. I'm okay with renaming these and making them non-CHROMEOS-specific if that's useful (although I'm not sure the name `bootmode` really fits for everything there... maybe just `gpios.c` or `board.c`? We often call the header that defines GPIO constants `board.h`, after all...), but I'd prefer them to stay all in one file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59011
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71a02c5fa1b256316b86b673660bf22dfd284f7f
Gerrit-Change-Number: 59011
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 12 Apr 2022 18:01:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment