Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38631 )
Change subject: util/inteltool: Split GPIO community switch-case into its own function
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38631/2/util/inteltool/gpio_groups....
File util/inteltool/gpio_groups.c:
https://review.coreboot.org/c/coreboot/+/38631/2/util/inteltool/gpio_groups....
PS2, Line 99: get_gpio_communitys
communities
Don't forget! get_gpio_communities
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38631
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I215c1b7d6ec164b8afd9489ebd54b63d3df50cb9
Gerrit-Change-Number: 38631
Gerrit-PatchSet: 3
Gerrit-Owner: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Mar 2020 21:16:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment