Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36548 )
Change subject: drivers/intel/fsp2_0: Use strip_quotes for cbfs filenames ......................................................................
drivers/intel/fsp2_0: Use strip_quotes for cbfs filenames
The quotes were not stripped for the cbfs filenames of the FSP components. This is causing problems when the regions_for_file macro is executed.
BUG=N/A TEST=build
Change-Id: I14267502cfab5308d3874a0c0fd18a71b08bb9f8 Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/drivers/intel/fsp2_0/Makefile.inc 1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/36548/1
diff --git a/src/drivers/intel/fsp2_0/Makefile.inc b/src/drivers/intel/fsp2_0/Makefile.inc index 8e69377..44f43df 100644 --- a/src/drivers/intel/fsp2_0/Makefile.inc +++ b/src/drivers/intel/fsp2_0/Makefile.inc @@ -44,23 +44,23 @@
# Add FSP blobs into cbfs. SoC code may supply additional options with # -options, e.g --xip or -b -cbfs-files-$(CONFIG_FSP_CAR) += $(CONFIG_FSP_T_CBFS) -$(CONFIG_FSP_T_CBFS)-file := $(call strip_quotes,$(CONFIG_FSP_T_FILE)) -$(CONFIG_FSP_T_CBFS)-type := fsp +cbfs-files-$(CONFIG_FSP_CAR) += $(call strip_quotes,$(CONFIG_FSP_T_CBFS)) +$(call strip_quotes,$(CONFIG_FSP_T_CBFS))-file := $(call strip_quotes,$(CONFIG_FSP_T_FILE)) +$(call strip_quotes,$(CONFIG_FSP_T_CBFS))-type := fsp ifeq ($(CONFIG_FSP_T_XIP),y) -$(CONFIG_FSP_T_CBFS)-options := --xip $(TXTIBB) +$(call strip_quotes,$(CONFIG_FSP_T_CBFS))-options := --xip $(TXTIBB) endif
-cbfs-files-$(CONFIG_ADD_FSP_BINARIES) += $(CONFIG_FSP_M_CBFS) -$(CONFIG_FSP_M_CBFS)-file := $(call strip_quotes,$(CONFIG_FSP_M_FILE)) -$(CONFIG_FSP_M_CBFS)-type := fsp +cbfs-files-$(CONFIG_ADD_FSP_BINARIES) += $(call strip_quotes,$(CONFIG_FSP_M_CBFS)) +$(call strip_quotes,$(CONFIG_FSP_M_CBFS))-file := $(call strip_quotes,$(CONFIG_FSP_M_FILE)) +$(call strip_quotes,$(CONFIG_FSP_M_CBFS))-type := fsp ifeq ($(CONFIG_FSP_M_XIP),y) -$(CONFIG_FSP_M_CBFS)-options := --xip $(TXTIBB) +$(call strip_quotes,$(CONFIG_FSP_M_CBFS))-options := --xip $(TXTIBB) endif
-cbfs-files-$(CONFIG_ADD_FSP_BINARIES) += $(CONFIG_FSP_S_CBFS) -$(CONFIG_FSP_S_CBFS)-file := $(call strip_quotes,$(CONFIG_FSP_S_FILE)) -$(CONFIG_FSP_S_CBFS)-type := fsp +cbfs-files-$(CONFIG_ADD_FSP_BINARIES) += $(call strip_quotes,$(CONFIG_FSP_S_CBFS)) +$(call strip_quotes,$(CONFIG_FSP_S_CBFS))-file := $(call strip_quotes,$(CONFIG_FSP_S_FILE)) +$(call strip_quotes,$(CONFIG_FSP_S_CBFS))-type := fsp
ifeq ($(CONFIG_FSP_USE_REPO),y) $(obj)/Fsp_M.fd: $(call strip_quotes,$(CONFIG_FSP_FD_PATH))