Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36065 )
Change subject: mainboard/google: Add initial Puff board support
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36065/3/src/mainboard/google/puff/c...
File src/mainboard/google/puff/chromeos.c:
https://review.coreboot.org/c/coreboot/+/36065/3/src/mainboard/google/puff/c...
PS3, Line 28: {-1, ACTIVE_HIGH, get_lid_switch(), "lid"},
I guess lid is always open, so we can put 1 instead of get_lid_switch() as in fizz.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36065
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc8b13471e6e0b8cf540c35c712089c3205a3497
Gerrit-Change-Number: 36065
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 24 Oct 2019 05:54:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment