Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: mb/ongy/h61m-s1: Add new mainboard {LGA1155, H61} + Documentation ......................................................................
Patch Set 36:
(7 comments)
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.md:
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 48: - There is no automatic, OS-independent fan control. : The `coretemp` driver can still be used for : accurate CPU temperature readings. Your board doesn't have a SuperIO, so it doesn't really have this
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 51: - me_cleaner breaks LPC bus and attached components! I don't think your board has anything on the LPC bus
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 52: - Tianocore payload. The reason is yet undiscovered. Did you select a linear high-resolution framebuffer under menuconfig --> Devices --> Display ? tianocore needs that
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 57: 1x x1
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 66: - Your board doesn't have a SuperIO, so it doesn't really have this
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... PS36, Line 94: https://github.com/skollrc/coreboot_ongy_h61m-s1_port/blob/master/ROM_AND_DO... Is this manual available elsewhere?
https://review.coreboot.org/c/coreboot/+/40813/36/Documentation/mainboard/on... File Documentation/mainboard/ongy/h61m-s1.png:
PS36: This picture is really blurry and very large. It should be about 50 KiB at most