Attention is currently required from: Christian Walter, Intel coreboot Reviewers, Johnny Lin, Jonathan Zhang, Jérémy Compostella, Maximilian Brune, Tim Chu.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85806?usp=email )
Change subject: cpu/x86/64bit: Install extended page tables in BSS
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Considering that we use 1GB pages for almost all platforms (especially the more recent ones) we don' […]
It's not about DRAM, but about MMIO. There's nothing in coreboot caring about/using DRAM above 4GiB. But MMIO can be anywhere in the address space, usually way beyond the possible usable/maximum DRAM space.
It would be possible to introduce `CPU_PT_ROM_MAP_GB_RAMSTAGE`, use it only for ramstage and let the SoC set an arbitrary limit that satisfies the needs in ramstage. It would generate big page-table in RO memory as it's currently done by `CPU_PT_ROM_MAP_GB`. There's a huge downside to this approach:
You cannot use BSS. BSS is free and doesn't need space in the SPI flash, nor in the CBFS stage cache. RO-memory needs space in the SPI flash and the CBFS stage cache.
Thus using big (2.1 MiB) page-tables in RO-memory does:
- Increase the size on SPI flash (depending on compression just a bit)
- Increase the stage loading times
- Increase the size used in the CBFS stage cache
With the current approach the SPI flash size and CBFS stage cache size remains the same.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85806?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifab50975e0382a1f5c27b55bca1dbbb66b37ba3a
Gerrit-Change-Number: 85806
Gerrit-PatchSet: 6
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jincheng Li
jincheng.li@intel.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 26 Feb 2025 12:22:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com