Attention is currently required from: Raul Rangel, Jon Murphy, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74095 )
Change subject: mb/google/myst: First pass GPIO configuration for Myst
......................................................................
Patch Set 14:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74095/comment/918dd27d_8f69caf1
PS14, Line 7: First pass GPIO configuration for Myst
Please make it a statement by adding a verb (in imperative mood):
Add GPIO initial configuration
(“for Myst” is also redundant.)
https://review.coreboot.org/c/coreboot/+/74095/comment/b7be3070_10e78d67
PS14, Line 9: Initial GPIO configuration for Myst.
What source did you use?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia019704c7b027f14d46281e0de0ffdbc4906a20b
Gerrit-Change-Number: 74095
Gerrit-PatchSet: 14
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer
markhas@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Mark Hasemeyer
markhas@google.com
Gerrit-Comment-Date: Wed, 05 Apr 2023 21:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment