[coreboot-gerrit] Change in coreboot[master]: mb/pcengines/apu2: Switch to proper GPIO API

[Felix Held (Code Review)]

Attention is currently required from: Kyösti Mälkki.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42521 )

Change subject: mb/pcengines/apu2: Switch to proper GPIO API
......................................................................

Patch Set 15: Code-Review+1

(3 comments)

Patchset:

PS15: 
looks good to me. did you run a test on the board?

File src/mainboard/pcengines/apu2/gpio_ftns.c:

https://review.coreboot.org/c/coreboot/+/42521/comment/cbef38f0_57b23c88 
PS8, Line 50: 	iomux_write8(gpio, iomux_ftn & 0x3);
> good question. […]

i'd say this can be marked as resolved

File src/mainboard/pcengines/apu2/romstage.c:

https://review.coreboot.org/c/coreboot/+/42521/comment/ff743c55_faf0db54 
PS8, Line 43: 	gpio_output(gpio, 0);
> fyi: the patch that fixed the corresponding issue in soc/amd/common is submitted now, so the workaro […]

Done