Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37528 )
Change subject: src/mainboard: Fix typo
......................................................................
Patch Set 2: -Code-Review
You do realise that there is little point leaving out the disabled boards from change like this? As some of those seem to be salvaged from removal, we just end up reviewing these typo fixes again.
Same goes for fixups on includes, just apply them on the currently disabled boards as well if you see valid reasons. If they fail build-test once (if) re-enabled for builds, I think it is better to apply fixups then individually as required.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37528
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a486ce12d6a5f6de31afd279612dc37d3fffd83
Gerrit-Change-Number: 37528
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 31 Dec 2019 09:47:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment