Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45220 )
Change subject: xeon_sp/skx: Reorder pci_devs.h
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Need to fix the cpx change and verify with TiagoPass BUILD_TIMELESS.
https://review.coreboot.org/c/coreboot/+/45220/2/src/soc/intel/xeon_sp/cpx/i...
File src/soc/intel/xeon_sp/cpx/include/soc/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/45220/2/src/soc/intel/xeon_sp/cpx/i...
PS2, Line 106: #define IIO_CBDMA_MMIO_ALIGNMENT 14 //2^14 - 16kB
I don't think you meant to add this line in this commit?
correct, It was meant for the skx file. I merged incorrectly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45220
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I939707cc9e58e23f053156f40df4c21a6072570b
Gerrit-Change-Number: 45220
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Bryant Ou
bryant.ou.q@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Sep 2020 17:03:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment