22 Nov
2019
22 Nov
'19
10 a.m.
ashk@codeaurora.org has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35506 )
Change subject: trogdor: support mbn_version 6 with python build scripts ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/mbn_tools.py File util/qualcomm/mbn_tools.py:
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/mbn_tools.py... PS17, Line 2134: if header_version == MBN_HEADER_VERSION_6:
Sorry this was supposed to say " > 5" before markdown got there.
All the review comments will be addressed by Rishabh Sharma. He is looking in to it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35506
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I020d1e4d4f5c948948e1b39dd18af1d0e860c279
Gerrit-Change-Number: 35506
Gerrit-PatchSet: 18
Gerrit-Owner: mturney mturney mturney@codeaurora.org
Gerrit-Reviewer: Douglas Anderson dianders@chromium.org
Gerrit-Reviewer: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Julius Werner jwerner@chromium.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: ashk@codeaurora.org
Gerrit-Comment-Date: Fri, 22 Nov 2019 10:00:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment