Attention is currently required from: Matt DeVillier.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74602 )
Change subject: mb/google/link: Apply symmetry for EC events defines
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/link/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74602/comment/194971a3_84796b28
PS4, Line 111: mainboard_ec_init();
looks like this is missing a declaration
Yeah, <ec/ec.h>, existing "ec.h" did not make it.
I'll get back to this mb-smihandler after tagged release.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74602
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97d9d28963c97e780156d75b39deac069028866a
Gerrit-Change-Number: 74602
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Rosa Franzini
danielt3@usp.br
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Tue, 02 May 2023 14:29:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment