[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/acpi: Add provision for multiple PCI segments

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40335 )

Change subject: soc/intel/common/block/acpi: Add provision for multiple PCI segments
......................................................................

Patch Set 5:

(2 comments)

https://review.coreboot.org/c/coreboot/+/40335/5/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/40335/5/src/soc/intel/common/block/... 
PS5, Line 43: seg_nr = pciex_bus / 256;
> Doesn't this need _SEG to be updated as well?

Sorry, i didn't get your point here

https://review.coreboot.org/c/coreboot/+/40335/5/src/soc/intel/common/block/... 
PS5, Line 46: acpi_create_mcfg_mmconfig((void *)current,
            : 			CONFIG_MMCONF_BASE_ADDRESS, seg_nr, 0, bus_end_nr);
> Don't you need an entry for each segment of 256 buses? I haven't looked at the ACPI table descriptio […]

As per ACPI MCFG table i believe we are good as i don't see any ACPI entry for multi segment