[coreboot-gerrit] Change in coreboot[master]: include/spi-generic: moving common flash timeouts

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34345 )

Change subject: include/spi-generic: moving common flash timeouts
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34345/3/src/include/spi-generic.h 
File src/include/spi-generic.h:

https://review.coreboot.org/c/coreboot/+/34345/3/src/include/spi-generic.h@2... 
PS3, Line 26: #define SPI_FLASH_SECTOR_ERASE_TIMEOUT	(10 * CONF_SYS_HZ)
nit: While we're here, do we maybe want to clean these up a little? Does anyone understand what CONF_SYS_HZ is supposed to be? I don't. Looks like these numbers turn out to be milliseconds, so it's probably clearer to just write 200, 500 and 1000 directly (and ideally rename the constants to end in _MS, or at least put a comment about the unit here).