Attention is currently required from: Xi Chen, Chien-Chih Tseng, Pi-Cheng Chen, Rex-BC Chen, flora.fu@mediatek.com. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48622 )
Change subject: soc/mediatek/mt8192: add apusys init flow ......................................................................
Patch Set 11:
(7 comments)
File src/soc/mediatek/mt8192/apusys.c:
https://review.coreboot.org/c/coreboot/+/48622/comment/138c9d86_864f87d4 PS11, Line 19: 0x%p %p
("0x" will be printed with "%p")
https://review.coreboot.org/c/coreboot/+/48622/comment/da1cb01e_a33ed6e3 PS11, Line 20: (void *) Align with BIOS_INFO
https://review.coreboot.org/c/coreboot/+/48622/comment/e4dc33ed_9276e381 PS11, Line 23: SIZE_MBOX_FUN ARRAY_SIZE(mt8192_apu_mbox)
https://review.coreboot.org/c/coreboot/+/48622/comment/6dc6f283_604b511d PS11, Line 24: 0x%p %p
https://review.coreboot.org/c/coreboot/+/48622/comment/8023dda8_edfbdc76 PS11, Line 25: (void *) Align with BIOS_INFO
https://review.coreboot.org/c/coreboot/+/48622/comment/29c43588_43b2912a PS11, Line 37: SIZE_MBOX_FUN ARRAY_SIZE(mt8192_apu_mbox)
File src/soc/mediatek/mt8192/include/soc/apusys.h:
https://review.coreboot.org/c/coreboot/+/48622/comment/54b22b5e_72fc1d38 PS11, Line 9: SIZE_MBOX_FUN Using the ARRAY_SIZE macro, I don't think we need this.