Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44512 )
Change subject: soc/intel/common: Call pci_dev_enable_bus_master() from .final ops
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44512/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44512/2//COMMIT_MSG@15
PS2, Line 15: access
Not sure what you mean here. To access PCI device resources PCI_COMMAND_IO and PCI_COMMAND_MEMORY should be sufficient. Which device needs PCI_COMMAND_MASTER and why can't the payload or OS set PCI_COMMAND_MASTER?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44512
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife65f6029d2f966e321f616e85f59f4c37c42145
Gerrit-Change-Number: 44512
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Mon, 17 Aug 2020 09:19:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment