Attention is currently required from: Sean Rhodes, Martin Roth, Tim Wawrzynczak, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58854 )
Change subject: [WIP] util: Add coreboot Configurator ......................................................................
Patch Set 19:
(140 comments)
File util/coreboot-configurator/src/Documentation.txt:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/bfd0d021_00b0930e PS19, Line 5: This allows `coreboot-configurator` to display them in a relavant tab, with a nice 'relavant' may be misspelled - perhaps 'relevant'?
File util/coreboot-configurator/src/application/aboutwindow.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/f9225f28_4673d031 PS19, Line 16: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/63ee51a9_2e086fdf PS19, Line 17: explicit aboutWindow(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/e602e543_4c769b91 PS19, Line 21: Ui::aboutWindow *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/f009e626_90f5faa9 PS19, Line 21: Ui::aboutWindow *ui; labels should not be indented
File util/coreboot-configurator/src/application/configuration.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/16c60ec4_105504a5 PS19, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/5559aa3e_c0fbe961 PS19, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/9dc0aa35_91641cbe PS19, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/e56d2df7_09bdf340 PS19, Line 13: QMap<QString,QString> fromFile(const QString& curr_path); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/cfc925fe_65e060d5 PS19, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/1fd80790_5622641a PS19, Line 15: QMap<QString,QString> fromNvramTool(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/cbc42c86_997d06e6 PS19, Line 15: QMap<QString,QString> fromNvramTool(); spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ac4d4793_769b68df PS19, Line 17: QMap<QString,QString> mocked(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/eee2ac39_3727498d PS19, Line 17: QMap<QString,QString> mocked(); space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/85e04685_29c1cce8 PS19, Line 17: QMap<QString,QString> mocked(); spaces required around that '>' (ctx:VxW)
File util/coreboot-configurator/src/application/coreboot_configurator.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/b4182b2d_8a7c5760 PS19, Line 29: public: spaces required around that ':' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/669a2292_e687eeb1 PS19, Line 30: coreboot_configurator(QWidget *parent = nullptr); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/b7d693a5_c6ed0738 PS19, Line 37: void showEvent(QShowEvent *ev); need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/3d3ec8d7_a8832698 PS19, Line 48: void displaySettings(); Bad function definition - void displaySettings() should probably be void displaySettings(void)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/b006555e_a08781d0 PS19, Line 52: void writeToFile(const QString& out_file); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/6f21ac8f_273a25a5 PS19, Line 55: void updateValue(const QString& name); need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/520582fa_76bfc170 PS19, Line 61: QMap<QString, QString> m_values; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/9a925d65_3355ab2f PS19, Line 61: QMap<QString, QString> m_values; spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/49d96b34_070db83a PS19, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/2094b6fb_35a723d6 PS19, Line 64: QMap<QString, QVBoxLayout*> m_tabs; spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/669248a6_5fa058cf PS19, Line 67: YAML::Node m_categories; labels should not be indented
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/61de2392_08f2197e PS19, Line 70: QComboBox *textToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/bee686af_6eaf87a4 PS19, Line 71: QCheckBox *checkToDisplay(const QString &in_string); need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/c151783e_c115fb1d PS19, Line 73: Ui::coreboot_configurator *ui; need consistent spacing around '*' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/16cb1d8f_51e38ef8 PS19, Line 73: Ui::coreboot_configurator *ui; labels should not be indented
File util/coreboot-configurator/src/application/qtyaml.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/571f11a1_954da33f PS19, Line 17: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/b77f76e7_32827c3f PS19, Line 17: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ba4cf46a_b145b5b0 PS19, Line 18: struct convert<QString> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/7defcbd1_56fce2c0 PS19, Line 18: struct convert<QString> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/961c990c_eac14978 PS19, Line 20: static Node encode(const QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/e28c2d30_f6e554d5 PS19, Line 20: static Node encode(const QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/4a01a1b9_2f91125a PS19, Line 25: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/2e6bf77a_9e960eb7 PS19, Line 25: static bool decode(const Node& node, QString& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ec17877d_1025a8bd PS19, Line 25: static bool decode(const Node& node, QString& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/a82fdf72_b6f52630 PS19, Line 35: template<typename Key, typename Value> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/9e5c2da3_a9c34b66 PS19, Line 35: template<typename Key, typename Value> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/77e43b93_730d6962 PS19, Line 36: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/f33f5d6a_e380f069 PS19, Line 36: struct convert<QMap<Key, Value> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/bf1b16aa_bae642c2 PS19, Line 36: struct convert<QMap<Key, Value> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/d93121a4_fb5d0eea PS19, Line 38: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/d1b70c9a_54eab5c1 PS19, Line 38: static Node encode(const QMap<Key,Value>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/8a05a320_02d37028 PS19, Line 38: static Node encode(const QMap<Key,Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ea10ab23_1a71c1cd PS19, Line 38: static Node encode(const QMap<Key,Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/88bc95b1_ff2af8d0 PS19, Line 38: static Node encode(const QMap<Key,Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/fa4299a0_524f9d6f PS19, Line 38: static Node encode(const QMap<Key,Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/3636bf61_b92eb85a PS19, Line 42: while (it != rhs.constEnd()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/e7913f69_271623e6 PS19, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/d895aa9e_9d29656f PS19, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/272d11ee_6f0c7d8a PS19, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/9d29cc98_c5ddc49c PS19, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/c60c7a86_fe5e28ec PS19, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/cf24158a_8efa5e41 PS19, Line 50: static bool decode(const Node& node, QMap<Key, Value>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ab835a5b_2c3c1377 PS19, Line 57: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/c3f92ec0_4eb4bc28 PS19, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ce18a9ed_a9519869 PS19, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/37fb2f94_d17a8555 PS19, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/9ae02c17_52a742f3 PS19, Line 59: rhs[it->first.as<Key>()] = it->second.as<Value>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/8fa969f5_8e8d3a6f PS19, Line 67: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/5a32f9d1_12d466b8 PS19, Line 67: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/c8e077de_0eb826a1 PS19, Line 68: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/623b486d_c2516d87 PS19, Line 68: struct convert<QVector<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/294a5b62_d3c763a7 PS19, Line 68: struct convert<QVector<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/37cf3823_9b1a836b PS19, Line 70: static Node encode(const QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/8e57dab3_4a3adb15 PS19, Line 70: static Node encode(const QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/c97a4058_006d7808 PS19, Line 70: static Node encode(const QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/091fd1cc_c4ac6757 PS19, Line 70: static Node encode(const QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/058c3c40_d0999d61 PS19, Line 70: static Node encode(const QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/1e66192b_1404d88c PS19, Line 73: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/d820b735_16c11ad9 PS19, Line 79: static bool decode(const Node& node, QVector<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/4eef44d7_a023323f PS19, Line 79: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/c27f1466_bfafad34 PS19, Line 79: static bool decode(const Node& node, QVector<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/469aa366_9fc2840a PS19, Line 79: static bool decode(const Node& node, QVector<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/a6001fb5_ad71e901 PS19, Line 79: static bool decode(const Node& node, QVector<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/e628141a_0de22b6e PS19, Line 79: static bool decode(const Node& node, QVector<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/4b41223e_df99ab6b PS19, Line 86: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/3bcfd78e_fd346d2d PS19, Line 88: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/7e303e86_57e110d6 PS19, Line 88: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/30451951_f2a59d12 PS19, Line 96: template<typename T> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/161521d0_b4f046b0 PS19, Line 96: template<typename T> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/dccb092b_5c0a3721 PS19, Line 97: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/941f407b_b8473c8d PS19, Line 97: struct convert<QList<T> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/8cff7217_0076f146 PS19, Line 97: struct convert<QList<T> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/612cf353_86f6ed56 PS19, Line 99: static Node encode(const QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/cbb0a1b9_bbb9f460 PS19, Line 99: static Node encode(const QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/32dc94d8_beffd61a PS19, Line 99: static Node encode(const QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/765593e3_95b68e15 PS19, Line 99: static Node encode(const QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/fbb9dba1_93929950 PS19, Line 99: static Node encode(const QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/5a058112_16b7911c PS19, Line 102: foreach (T value, rhs) { space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/935bdce9_0cdfeda4 PS19, Line 108: static bool decode(const Node& node, QList<T>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/189815cc_ed8c469d PS19, Line 108: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/e9a94f67_0ee08d5a PS19, Line 108: static bool decode(const Node& node, QList<T>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/88d8ec0f_f7d4bd56 PS19, Line 108: static bool decode(const Node& node, QList<T>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/c224883b_9a147280 PS19, Line 108: static bool decode(const Node& node, QList<T>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/4712e1cc_6cc29a56 PS19, Line 108: static bool decode(const Node& node, QList<T>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/aab49e09_0bdcc21b PS19, Line 115: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/777abfea_d5aadb5e PS19, Line 117: rhs.push_back(it->as<T>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/4e247293_1386c66a PS19, Line 117: rhs.push_back(it->as<T>()); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/a4950e37_c6ffcf87 PS19, Line 125: template<typename T, typename U> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/54c59456_16666e7e PS19, Line 125: template<typename T, typename U> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/d02db1b2_0ba3432d PS19, Line 126: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/53b77cd3_16f69022 PS19, Line 126: struct convert<QPair<T,U> > spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/2bc6be50_37107495 PS19, Line 126: struct convert<QPair<T,U> > space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ef7b02fa_0d546789 PS19, Line 126: struct convert<QPair<T,U> > spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ab26baea_7d0236d2 PS19, Line 128: static Node encode(const QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ea6c6011_06a966d2 PS19, Line 128: static Node encode(const QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/cb0925e6_44c9d9fe PS19, Line 128: static Node encode(const QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/0d36cd61_34082995 PS19, Line 128: static Node encode(const QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/390765b7_63258f7e PS19, Line 128: static Node encode(const QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/96cd50a6_3441e7dc PS19, Line 128: static Node encode(const QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/914c77ce_32de22a8 PS19, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/a16ed532_e9538cd5 PS19, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/104932d7_868ae161 PS19, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/dae10919_15360cbc PS19, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/4e5db7eb_30270f12 PS19, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) space required before that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/96fd5ca3_d257ea50 PS19, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) space prohibited after that '&' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ded2b9db_eaf171b0 PS19, Line 136: static bool decode(const Node& node, QPair<T,U>& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/c6a763cd_b38d2fa6 PS19, Line 143: rhs.first = node[0].as<T>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/9ef5f06c_5d0f7d2a PS19, Line 143: rhs.first = node[0].as<T>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/37746649_40924d14 PS19, Line 144: rhs.second = node[1].as<U>(); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/5d85872f_2cc23124 PS19, Line 144: rhs.second = node[1].as<U>(); spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ee9f9a80_1c9e0d6b PS19, Line 150: template<> spaces required around that '<' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/490370f5_9f58ffa3 PS19, Line 150: template<> spaces required around that '>' (ctx:OxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/0dc72707_b2e7f193 PS19, Line 151: struct convert<QStringList> spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/9ef76caf_c3f22f77 PS19, Line 151: struct convert<QStringList> spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/fcd092c5_47f67a7f PS19, Line 153: static Node encode(const QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/2db39e24_a9427ccd PS19, Line 153: static Node encode(const QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ab300f6d_cd4b829b PS19, Line 156: for (const auto &value: rhs) { need consistent spacing around '&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/4a5f1986_2f6b7587 PS19, Line 156: for (const auto &value: rhs) { spaces required around that ':' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/8dbb6f31_720da069 PS19, Line 156: for (const auto &value: rhs) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/ca3e012f_26e17672 PS19, Line 162: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/2c1bb3d1_ccaf4a72 PS19, Line 162: static bool decode(const Node& node, QStringList& rhs) need consistent spacing around '&' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/e7544d0f_87d88f60 PS19, Line 162: static bool decode(const Node& node, QStringList& rhs) open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/2f0b9e33_6e173042 PS19, Line 169: while (it != node.end()) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/1f467216_b1ed4cbd PS19, Line 171: rhs.push_back(it->as<QString>()); spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132345): https://review.coreboot.org/c/coreboot/+/58854/comment/688a54d4_52105ac5 PS19, Line 171: rhs.push_back(it->as<QString>()); spaces required around that '>' (ctx:VxV)