Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45177 )
Change subject: soc/amd/picasso: Use lookup table to convert MHz to MT/s ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45177/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45177/2//COMMIT_MSG@7 PS2, Line 7: Mhz
MHz
Done
https://review.coreboot.org/c/coreboot/+/45177/2/src/soc/amd/picasso/dmi.c File src/soc/amd/picasso/dmi.c:
https://review.coreboot.org/c/coreboot/+/45177/2/src/soc/amd/picasso/dmi.c@3... PS2, Line 34: * e.g. 1333 Mhz == 1333.333 Mhz == 2666.666 MT/s == 26667 MT/s
It depends on what AGESA is returning in that case. Will it be returning 1466MHz or 1467MHz? […]
Done
https://review.coreboot.org/c/coreboot/+/45177/2/src/soc/amd/picasso/dmi.c@3... PS2, Line 36: dimm->configured_speed_mts = 2 * dmi17->ConfigSpeed; : if (dimm->configured_speed_mts % 100 == 66) : dimm->configured_speed_mts += 1; : else if (dimm->configured_speed_mts % 100 == 34) : dimm->configured_speed_mts -= 1;
Irrespective of whether you decide to go with adding check for 32 or using a table, I think this sho […]
Done