build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33912 )
Change subject: [WIP]superio/smsc: add SCH5636 Super I/O ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33912/2/src/superio/smsc/sch5636/sch5636.h File src/superio/smsc/sch5636/sch5636.h:
https://review.coreboot.org/#/c/33912/2/src/superio/smsc/sch5636/sch5636.h@2... PS2, Line 27: #define SCH5636_HWM /* HWM is done by the EC part */ line over 80 characters
https://review.coreboot.org/#/c/33912/2/src/superio/smsc/sch5636/superio.c File src/superio/smsc/sch5636/superio.c:
https://review.coreboot.org/#/c/33912/2/src/superio/smsc/sch5636/superio.c@2... PS2, Line 28: if (!dev->enabled) { braces {} are not necessary for single statement blocks