Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/36943 )
Change subject: Use binaries from Windows installer directly ......................................................................
Patch Set 14:
(5 comments)
https://review.coreboot.org/c/em100/+/36943/13/em100.c File em100.c:
https://review.coreboot.org/c/em100/+/36943/13/em100.c@656 PS13, Line 656: static int list_chips_entry(char *name __unused, TFILE *file, void *data __unused, int ok __unused)
Sanity check: the return value is always the same. […]
It is intended, 0 means continue != 0 means break after this. We want to iterate through the whole list of chips.
But I rewrote this function to only have one return statement and have the printf call in a reversed if block instead.
https://review.coreboot.org/c/em100/+/36943/13/em100.c@693 PS13, Line 693: dcfg
Sanity check: Is it needed to call `tar_close(dcfg)` before returning?
Done
https://review.coreboot.org/c/em100/+/36943/13/em100.c@989 PS13, Line 989: const
Why is this const if its value gets modified by `get_chip_type()`?
Good point.
https://review.coreboot.org/c/em100/+/36943/13/tar.c File tar.c:
https://review.coreboot.org/c/em100/+/36943/13/tar.c@87 PS13, Line 87: if(!ok)
missing space
Done
https://review.coreboot.org/c/em100/+/36943/13/tar.c@121 PS13, Line 121: if(!ok)
missing space
Done