5 comments:
Patch Set #13, Line 656: static int list_chips_entry(char *name __unused, TFILE *file, void *data __unused, int ok __unused)
Sanity check: the return value is always the same. […]
It is intended, 0 means continue != 0 means break after this. We want to iterate through the whole list of chips.
But I rewrote this function to only have one return statement and have the printf call in a reversed if block instead.
Sanity check: Is it needed to call `tar_close(dcfg)` before returning?
Done
Patch Set #13, Line 989: const
Why is this const if its value gets modified by `get_chip_type()`?
Good point.
Patch Set #13, Line 87: if(!ok)
missing space
Done
Patch Set #13, Line 121: if(!ok)
missing space
Done
To view, visit change 36943. To unsubscribe, or for help writing mail filters, visit settings.