11 Jul
2019
11 Jul
'19
5:12 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34195 )
Change subject: driver/spi: Drop HAVE_SMI_HANDLER dependency ......................................................................
Patch Set 1:
I suppose this is needed for the `select ELOG...` in `src/vendorcode/google/chromeos/Kconfig`. I don't know how it works on non-x86 platforms, on x86, this should probably be disabled `if !HAVE_SMI_HANDLER`? Or should `config CHROMEOS` select `HAVE_SMI_HANDLER`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34195
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I620d3ce5aa9632d862d6480922144f002cf6423b
Gerrit-Change-Number: 34195
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Thu, 11 Jul 2019 15:12:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment