Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32044 )
Change subject: soc/intel/skylake: Update GFX devtree options
......................................................................
Patch Set 8: Code-Review+2
(2 comments)
Please update the commit message before merge.
https://review.coreboot.org/#/c/32044/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32044/8//COMMIT_MSG@15
PS8, Line 15: - SkipExtGfxScan.
Not part of this patch anymore?
https://review.coreboot.org/#/c/32044/8/src/soc/intel/skylake/romstage/romst...
File src/soc/intel/skylake/romstage/romstage_fsp20.c:
https://review.coreboot.org/#/c/32044/8/src/soc/intel/skylake/romstage/romst...
PS8, Line 258: if (config->PrimaryDisplay == Display_iGFX)
: m_cfg->PrimaryDisplay = Display_Auto;
: else
Is this really necessary? If I understand your findings correctly,
FSP would fall back by itself if the "primary adapter" doesn't exist?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32044
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3f9362676105e41c69139a094dbb9e8b865689f
Gerrit-Change-Number: 32044
Gerrit-PatchSet: 8
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Gaggery Tsai
gaggery.tsai@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Youness Alaoui
snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-Comment-Date: Fri, 05 Apr 2019 16:02:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment