Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31649 )
Change subject: console: Add timestamp prints to boot stages.
......................................................................
Patch Set 3:
The purpose is to be able to match up events between coreboot's logs and say, an EC log as well. I have a corresponding patch in the ChromeOS EC codebase which prints the RTC time at certain stages in the boot sequence as well.
Well, so for Chrome OS, don't we already have that? Every boot should include a
ELOG: Event(17) added with size 13 at 2018-05-24 02:19:10 UTC
line somewhere in ramstage. Just use that? No need to more RTC queries than needed (they aren't always cheap).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31649
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27676ceac8bccc56ac3d775915f217c8b3c47f4d
Gerrit-Change-Number: 31649
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Assignee: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 27 Feb 2019 20:40:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment