Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32176 )
Change subject: mb/google/hatch: Update GPIO settings
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/...
PS4, Line 32: PAD_NC(GPP_A7, NONE),
CS1 is not being configured in FSP.
This is really weird. It seems completely broken to me. How does FSP decide which CS has to be configured?
https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/...
PS4, Line 345: Set to NF1
Keep as SD_WP to match the other comments.
https://review.coreboot.org/#/c/32176/4/src/mainboard/google/hatch/variants/...
PS4, Line 346: DN_20K
Does FSP configure this too?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32176
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4549ac7377d7f58f51cda0eb96a62604fd31d2f2
Gerrit-Change-Number: 32176
Gerrit-PatchSet: 4
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 16 Apr 2019 23:57:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rizwan Qureshi
rizwan.qureshi@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment
