EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40560 )
Change subject: soc/intel/tigerlake: Check SPD is not NULL before print
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40560/4/src/soc/intel/tigerlake/mem...
File src/soc/intel/tigerlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/40560/4/src/soc/intel/tigerlake/mem...
PS4, Line 316: blk->addr_map[i] &&
This check is redundant now because get_spd_smbus() returns NULL if addr_map[i] is 0.
agree :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40560
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccd9fce99eda7ae2b8fb1b4f3c2e635c2a428f04
Gerrit-Change-Number: 40560
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.corp-partner.google.com
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Thu, 23 Apr 2020 15:50:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment