Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31592 )
Change subject: ACPI: Correct acpi_tables ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31592/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31592/3//COMMIT_MSG@7 PS3, Line 7: ACPI: Correct acpi_tables This basically says nothing. "Correct" to what meaning?
First, we have to decide what should be in this enum. If we don't define it exactly, anybody could push a commit that "corrects" it for any reason.
My personal preference would be "what we use". That'd currently only be tables that get_acpi_table_revision() knows about.
Alternatively, we could make it everything that was ever specified as table by ACPI, plus proprietary tables that coreboot provides too. I don't like dropping obso- lete tables as that makes it even more confusing (and increases patch noise). I think this might be the ori- ginally intended definition.
The former would be much clearer and easier to main- tain, IMHO. I'm open for other definitions as well, as long as it is reasonably maintainable. And doesn't create more noise (e.g. gets fixed just for the sake of its useless definition).