10 Jul
2019
10 Jul
'19
noon
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34188 )
Change subject: mb/google/octopus/variants/garg: support LTE power sequence. ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34188/6/src/mainboard/google/octopu... File src/mainboard/google/octopus/smihandler.c:
https://review.coreboot.org/c/coreboot/+/34188/6/src/mainboard/google/octopu... PS6, Line 37: gpio_get_output Just curious: can we not use sku id to determine if it is a LTE SKU and then do the power off sequence? That way we don't have to introduce this new function?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34188
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bf6fee087c885c22363b44aa98aa61f91be90b4
Gerrit-Change-Number: 34188
Gerrit-PatchSet: 6
Gerrit-Owner: Marco Chen marcochen@google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Justin TerAvest teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Kevin Chiu kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen marcochen@chromium.org
Gerrit-Reviewer: Marco Chen marcochen@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 10 Jul 2019 19:00:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment