Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29434 )
Change subject: mb/lenovo/x220: Add x1 as a variant ......................................................................
Patch Set 5: Code-Review+1
(4 comments)
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... File src/mainboard/lenovo/x220/variants/x1/devicetree.cb:
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 71: 0, 0, 0, 0, 0, 0, 0, 0 The Expresscard port should have a one here.
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 79: 0x2005 Does it have two flash chips ? It's not clear from the documentation.
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 104: on What's behind those ports ? One might be for Expresscard.
https://review.coreboot.org/#/c/29434/5/src/mainboard/lenovo/x220/variants/x... PS5, Line 173: has_bdc_detection Does BDC detection properly work ? Maybe it was fixed while updating the design.